[PATCH] Initial DWARF64 support for .debug_line

Alexey Samsonov vonosmas at gmail.com
Mon Jun 9 13:07:18 PDT 2014


I'm ok with this patch.

================
Comment at: test/DebugInfo/dwarfdump-64-bit-dwarf.test:1
@@ +1,2 @@
+RUN: llvm-dwarfdump %p/Inputs/dwarfdump-inl-test.elf-mips64-64-bit-dwarf \
+RUN:   --debug-dump=line | FileCheck %s
----------------
Is "inl-test" necessary in binary name? If not, please rename it.

================
Comment at: test/DebugInfo/dwarfdump-64-bit-dwarf.test:3
@@ +2,3 @@
+RUN:   --debug-dump=line | FileCheck %s
+
+CHECK:   total_length: 0x00000212
----------------
Please add a comment about limited DWARF-64 parsing capabilities.

http://reviews.llvm.org/D1988






More information about the llvm-commits mailing list