[llvm] r209907 - Fix MIPS exception personality encoding.
Daniel.Sanders at imgtec.com
Mon Jun 9 05:32:17 PDT 2014
That's ok. Joerg was happy with the patch so there's no harm done.
By the way, sorry for the slow reply. It seems I disappeared from the 'To:' header. I'm a bit behind on llvm-commits at the moment but I'm catching up.
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Logan Chien
Sent: 03 June 2014 15:01
To: llvm-commits at cs.uiuc.edu
Subject: [llvm] r209907 - Fix MIPS exception personality encoding.
Sorry for committing without a LGTM. I thought it was OK to commit since there was no further discussion. Sorry about this.
Thanks for your review.
On Tuesday, June 3, 2014, Joerg Sonnenberger <joerg at britannica.bec.de<mailto:joerg at britannica.bec.de>> wrote:
On Tue, Jun 03, 2014 at 09:10:03AM +0000, Daniel Sanders wrote:
> Hi Logan,
> I know that you addressed Joerg's comments at http://reviews.llvm.org/D3828 but I didn't see an LGTM (or words to that effect) for this patch so I think it was still being reviewed when you committed it.
> Joerg: Were you happy with the updated patch?
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits