[PATCH] [AArch64] Missing aliases for CMP/CMN [W]SP with no shift

Artyom Skrobov Artyom.Skrobov at arm.com
Mon Jun 9 04:20:34 PDT 2014

Thanks Tim! Committed as r210464.

On your question regarding ARM ARM, I don't see any ambiguity there: it gives the assembly strings for these encodings as

CMN <Wn|WSP>, <Wm>{, <extend> {#<amount>}}
CMN <Xn|SP>, <R><m>{, <extend> {#<amount>}}
CMP <Wn|WSP>, <Wm>{, <extend> {#<amount>}}
CMP <Xn|SP>, <R><m>{, <extend> {#<amount>}}

-- indicating that WSP and SP are permitted as the first operand, and that the <extend> block is optional.

What ambiguity did you mean?

-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: 09 June 2014 11:03
To: Artyom Skrobov
Cc: llvm-commits
Subject: Re: [PATCH] [AArch64] Missing aliases for CMP/CMN [W]SP with no shift

Hi Artyom,

On 5 June 2014 11:48, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:
> Our new patch adds the two aliases which were missing for CMP/CMN [W]SP with no shift, as well as updates the tests.
> OK to commit?

This looks reasonably sensible, so you should probably just commit it.
I see the ARM ARM leaves this ambiguous though, is that being fixed?



More information about the llvm-commits mailing list