[llvm] r210408 - test: move some tests into ARM directory

Alp Toker alp at nuanti.com
Sat Jun 7 18:45:57 PDT 2014


On 08/06/2014 04:04, Saleem Abdulrasool wrote:
> Author: compnerd
> Date: Sat Jun  7 20:04:05 2014
> New Revision: 210408
>
> URL: http://llvm.org/viewvc/llvm-project?rev=210408&view=rev
> Log:
> test: move some tests into ARM directory
>
> Rather than requiring ARM support for the ELF tests (which is odd), move the
> tests that require ARM into a subdirectory to use lit to disable them if the
> support is not present.  Play this game to prevent disabling the ELF tests on
> the Windows build bots as they have caught issues in the past with interactions
> between various platforms.
>
> Added:
>      llvm/trunk/test/MC/ELF/ARM/
>      llvm/trunk/test/MC/ELF/ARM/gnu-type-hash-diagnostics.s
>        - copied, changed from r210407, llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s
>      llvm/trunk/test/MC/ELF/ARM/gnu-type-hash.s
>        - copied, changed from r210407, llvm/trunk/test/MC/ELF/gnu-type-hash.s
>      llvm/trunk/test/MC/ELF/ARM/lit.local.cfg
> Removed:
>      llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s
>      llvm/trunk/test/MC/ELF/gnu-type-hash.s
>
> Copied: llvm/trunk/test/MC/ELF/ARM/gnu-type-hash-diagnostics.s (from r210407, llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s)
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/ARM/gnu-type-hash-diagnostics.s?p2=llvm/trunk/test/MC/ELF/ARM/gnu-type-hash-diagnostics.s&p1=llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s&r1=210407&r2=210408&rev=210408&view=diff
> ==============================================================================
>      (empty)
>
> Copied: llvm/trunk/test/MC/ELF/ARM/gnu-type-hash.s (from r210407, llvm/trunk/test/MC/ELF/gnu-type-hash.s)
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/ARM/gnu-type-hash.s?p2=llvm/trunk/test/MC/ELF/ARM/gnu-type-hash.s&p1=llvm/trunk/test/MC/ELF/gnu-type-hash.s&r1=210407&r2=210408&rev=210408&view=diff
> ==============================================================================
>      (empty)
>
> Added: llvm/trunk/test/MC/ELF/ARM/lit.local.cfg
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/ARM/lit.local.cfg?rev=210408&view=auto
> ==============================================================================
> --- llvm/trunk/test/MC/ELF/ARM/lit.local.cfg (added)
> +++ llvm/trunk/test/MC/ELF/ARM/lit.local.cfg Sat Jun  7 20:04:05 2014
> @@ -0,0 +1,4 @@
> +targets = set(config.root.targets_to_build.split())
> +if not 'ARM' in targets:
> +  config.unsupported = True
> +

Now the tests don't run unless X86 is also enabled.

Consider instead:

   config.unsupported = not 'ARM' in targets

Alp.


> Removed: llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s?rev=210407&view=auto
> ==============================================================================
> --- llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s (original)
> +++ llvm/trunk/test/MC/ELF/gnu-type-hash-diagnostics.s (removed)
> @@ -1,9 +0,0 @@
> -@ RUN: not llvm-mc -triple arm-elf -filetype asm -o /dev/null %s 2>&1 | FileCheck %s
> -
> -	.syntax unified
> -
> -	.type TYPE #32
> -// CHECK: error: expected symbol type in directive
> -// CHECK: .type TYPE #32
> -// CHECK:             ^
> -
>
> Removed: llvm/trunk/test/MC/ELF/gnu-type-hash.s
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/gnu-type-hash.s?rev=210407&view=auto
> ==============================================================================
> --- llvm/trunk/test/MC/ELF/gnu-type-hash.s (original)
> +++ llvm/trunk/test/MC/ELF/gnu-type-hash.s (removed)
> @@ -1,16 +0,0 @@
> -@ RUN: llvm-mc -triple arm-elf -filetype asm -o - %s | FileCheck %s
> -
> -	.syntax unified
> -
> -	.type TYPE #STT_FUNC
> -// CHECK: .type TYPE,%function
> -
> -	.type type #function
> -// CHECK: .type type,%function
> -
> -	.type comma_TYPE, #STT_FUNC
> -// CHECK: .type comma_TYPE,%function
> -
> -	.type comma_type, #function
> -// CHECK: .type comma_type,%function
> -
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list