[PATCH] Change base mutex implementations to use STL-provided mutexes

Zachary Turner zturner at google.com
Fri Jun 6 18:09:25 PDT 2014


On Fri, Jun 6, 2014 at 6:06 PM, Chandler Carruth <chandlerc at gmail.com>
wrote:

> Backing up a second, and setting aside all aspects of windows.h, I think
> this patch is going in the wrong direction at a very fundamental level.
>
> I think it is a really huge mistake for LLVM to continue to use its own
> Mutex class. I don't think you should change it, I think you should remove
> it, and use std::mutex. I understand that this may be hard, but I think
> time would be better spent working on those hard problems. I see a few
> elements that you'll need to address:
>

Actually this is fine with me.  This is the approach I wanted to take
originally, but I felt the current approach would be less controversial
since the semantics remained identical.  If there is enough consensus
surrounding this approach, I will re-evaluate my strategy.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140606/a1d565db/attachment.html>


More information about the llvm-commits mailing list