[compiler-rt] r210365 - tsan: fix argument passing in Go interface

Dmitry Vyukov dvyukov at google.com
Fri Jun 6 11:53:53 PDT 2014


Author: dvyukov
Date: Fri Jun  6 13:53:52 2014
New Revision: 210365

URL: http://llvm.org/viewvc/llvm-project?rev=210365&view=rev
Log:
tsan: fix argument passing in Go interface
Go calling convention does not support bools (it probably works, but uptrs are safer)



Modified:
    compiler-rt/trunk/lib/tsan/go/tsan_go.cc

Modified: compiler-rt/trunk/lib/tsan/go/tsan_go.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/go/tsan_go.cc?rev=210365&r1=210364&r2=210365&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/go/tsan_go.cc (original)
+++ compiler-rt/trunk/lib/tsan/go/tsan_go.cc Fri Jun  6 13:53:52 2014
@@ -191,17 +191,17 @@ void __tsan_finalizer_goroutine(ThreadSt
   AcquireGlobal(thr, 0);
 }
 
-void __tsan_mutex_before_lock(ThreadState *thr, uptr addr, bool write) {
+void __tsan_mutex_before_lock(ThreadState *thr, uptr addr, uptr write) {
 }
 
-void __tsan_mutex_after_lock(ThreadState *thr, uptr addr, bool write) {
+void __tsan_mutex_after_lock(ThreadState *thr, uptr addr, uptr write) {
   if (write)
     MutexLock(thr, 0, addr);
   else
     MutexReadLock(thr, 0, addr);
 }
 
-void __tsan_mutex_before_unlock(ThreadState *thr, uptr addr, bool write) {
+void __tsan_mutex_before_unlock(ThreadState *thr, uptr addr, uptr write) {
   if (write)
     MutexUnlock(thr, 0, addr);
   else





More information about the llvm-commits mailing list