[compiler-rt] r210346 - tsan: fix clang warning:

David Blaikie dblaikie at gmail.com
Fri Jun 6 09:13:11 PDT 2014


Should we try to fix the Clang warning so it doesn't fire on
possibly-implementation-defined constants like this?

On Fri, Jun 6, 2014 at 8:51 AM, Dmitry Vyukov <dvyukov at google.com> wrote:
> Author: dvyukov
> Date: Fri Jun  6 10:51:20 2014
> New Revision: 210346
>
> URL: http://llvm.org/viewvc/llvm-project?rev=210346&view=rev
> Log:
> tsan: fix clang warning:
> comparison of unsigned expression >= 0 is always true
>
>
> Modified:
>     compiler-rt/trunk/lib/tsan/rtl/tsan_platform.h
>
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_platform.h
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_platform.h?rev=210346&r1=210345&r2=210346&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_platform.h (original)
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_platform.h Fri Jun  6 10:51:20 2014
> @@ -131,6 +131,8 @@ static inline bool IsAppMem(uptr mem) {
>  #if defined(TSAN_COMPAT_SHADOW) && TSAN_COMPAT_SHADOW
>    return (mem >= kLinuxAppMemBeg && mem < kAppMemGapBeg) ||
>           (mem >= kAppMemGapEnd   && mem <= kLinuxAppMemEnd);
> +#elif defined(TSAN_GO)
> +  return mem <= kLinuxAppMemEnd;
>  #else
>    return mem >= kLinuxAppMemBeg && mem <= kLinuxAppMemEnd;
>  #endif
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list