[compiler-rt] r209862 - Mark currently failing ARM tests with XFAIL.

Evgeniy Stepanov eugeni.stepanov at gmail.com
Fri Jun 6 01:47:23 PDT 2014


I've switched android bot to the standalone build and these started
showing as "Unexpected Passing Tests". For some reason XFAIL: arm did
not apply to arm-android in non-standalone build, though it does not
matter now as it looks like we would be deprecating that.

Could this be changed to REQUIRES: stable-runtime or XFAIL:
unstable-runtime? Alternatively, we could introduce smth like
arm-linux for use in XFAIL.


On Fri, May 30, 2014 at 3:34 AM, Greg Fitzgerald <gregf at codeaurora.org> wrote:
> Author: garious
> Date: Thu May 29 18:34:47 2014
> New Revision: 209862
>
> URL: http://llvm.org/viewvc/llvm-project?rev=209862&view=rev
> Log:
> Mark currently failing ARM tests with XFAIL.
>
> Differential Revision: http://reviews.llvm.org/D3857
>
> Modified:
>     compiler-rt/trunk/test/asan/TestCases/Linux/clone_test.cc
>     compiler-rt/trunk/test/asan/TestCases/Linux/glob.cc
>     compiler-rt/trunk/test/asan/TestCases/Linux/heavy_uar_test.cc
>     compiler-rt/trunk/test/asan/TestCases/Linux/malloc_delete_mismatch.cc
>     compiler-rt/trunk/test/asan/TestCases/Linux/ptrace.cc
>     compiler-rt/trunk/test/asan/TestCases/Linux/stack-trace-dlclose.cc
>     compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-sanity-test.cc
>     compiler-rt/trunk/test/asan/TestCases/Posix/shared-lib-test.cc
>     compiler-rt/trunk/test/asan/TestCases/Posix/start-deactivated.cc
>     compiler-rt/trunk/test/asan/TestCases/deep_stack_uaf.cc
>     compiler-rt/trunk/test/asan/TestCases/double-free.cc
>     compiler-rt/trunk/test/asan/TestCases/gc-test.cc
>     compiler-rt/trunk/test/asan/TestCases/invalid-free.cc
>     compiler-rt/trunk/test/asan/TestCases/large_func_test.cc
>     compiler-rt/trunk/test/asan/TestCases/mmap_limit_mb.cc
>     compiler-rt/trunk/test/asan/TestCases/sanity_check_pure_c.c
>     compiler-rt/trunk/test/asan/TestCases/strncpy-overflow.cc
>     compiler-rt/trunk/test/asan/TestCases/use-after-delete.cc
>     compiler-rt/trunk/test/asan/TestCases/use-after-free-right.cc
>     compiler-rt/trunk/test/asan/TestCases/use-after-free.cc
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Linux/clone_test.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/clone_test.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Linux/clone_test.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Linux/clone_test.cc Thu May 29 18:34:47 2014
> @@ -5,6 +5,7 @@
>  // RUN: %clangxx_asan -O1 %s -o %t && %run %t | FileCheck %s
>  // RUN: %clangxx_asan -O2 %s -o %t && %run %t | FileCheck %s
>  // RUN: %clangxx_asan -O3 %s -o %t && %run %t | FileCheck %s
> +// XFAIL: arm
>
>  #include <stdio.h>
>  #include <sched.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Linux/glob.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/glob.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Linux/glob.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Linux/glob.cc Thu May 29 18:34:47 2014
> @@ -3,6 +3,7 @@
>  //
>  // RUN: %clangxx_asan -O0 %s -o %t && %run %t %p 2>&1 | FileCheck %s
>  // RUN: %clangxx_asan -O3 %s -o %t && %run %t %p 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #include <assert.h>
>  #include <glob.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Linux/heavy_uar_test.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/heavy_uar_test.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Linux/heavy_uar_test.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Linux/heavy_uar_test.cc Thu May 29 18:34:47 2014
> @@ -3,6 +3,7 @@
>  // RUN:   not %run %t 2>&1 | FileCheck %s
>  // RUN: %clangxx_asan -O2 %s -o %t && \
>  // RUN:   not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  // FIXME: Fix this test under GCC.
>  // REQUIRES: Clang
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Linux/malloc_delete_mismatch.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/malloc_delete_mismatch.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Linux/malloc_delete_mismatch.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Linux/malloc_delete_mismatch.cc Thu May 29 18:34:47 2014
> @@ -12,6 +12,7 @@
>  // Also works if no malloc context is available.
>  // RUN: ASAN_OPTIONS=alloc_dealloc_mismatch=1:malloc_context_size=0:fast_unwind_on_malloc=0 not %run %t 2>&1 | FileCheck %s
>  // RUN: ASAN_OPTIONS=alloc_dealloc_mismatch=1:malloc_context_size=0:fast_unwind_on_malloc=1 not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>  #include <stdlib.h>
>
>  static volatile char *x;
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Linux/ptrace.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/ptrace.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Linux/ptrace.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Linux/ptrace.cc Thu May 29 18:34:47 2014
> @@ -3,6 +3,7 @@
>  //
>  // RUN: %clangxx_asan -O0 %s -o %t && %run %t
>  // RUN: %clangxx_asan -DPOSITIVE -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #include <assert.h>
>  #include <stdio.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Linux/stack-trace-dlclose.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/stack-trace-dlclose.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Linux/stack-trace-dlclose.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Linux/stack-trace-dlclose.cc Thu May 29 18:34:47 2014
> @@ -4,6 +4,7 @@
>  // RUN: %clangxx_asan -DSHARED %s -shared -o %T/stack_trace_dlclose.so -fPIC
>  // RUN: %clangxx_asan -DSO_DIR=\"%T\" %s -o %t
>  // RUN: ASAN_OPTIONS=exitcode=0 %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #include <assert.h>
>  #include <dlfcn.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-sanity-test.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-sanity-test.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-sanity-test.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-sanity-test.cc Thu May 29 18:34:47 2014
> @@ -7,6 +7,7 @@
>  // RUN: %clangxx_asan -O0 -DSHARED_LIB %s -fPIC -shared -o %t-so.so
>  // RUN: %clangxx_asan -O0 %s -ldl -o %t
>  // RUN: env ASAN_OPTIONS=symbolize=0 not %run %t 2>&1 | %asan_symbolize | FileCheck %s
> +// XFAIL: arm
>
>  #if !defined(SHARED_LIB)
>  #include <dlfcn.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Posix/shared-lib-test.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/shared-lib-test.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Posix/shared-lib-test.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Posix/shared-lib-test.cc Thu May 29 18:34:47 2014
> @@ -6,6 +6,7 @@
>  // RUN: %clangxx_asan -O2 %s -ldl -o %t && not %run %t 2>&1 | FileCheck %s
>  // RUN: %clangxx_asan -O3 -DSHARED_LIB %s -fPIC -shared -o %t-so.so
>  // RUN: %clangxx_asan -O3 %s -ldl -o %t && not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #if !defined(SHARED_LIB)
>  #include <dlfcn.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Posix/start-deactivated.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/start-deactivated.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Posix/start-deactivated.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Posix/start-deactivated.cc Thu May 29 18:34:47 2014
> @@ -6,6 +6,7 @@
>  // RUN: %clangxx -O0 %s -c -o %t.o
>  // RUN: %clangxx_asan -O0 %t.o -ldl -o %t
>  // RUN: ASAN_OPTIONS=start_deactivated=1 not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #if !defined(SHARED_LIB)
>  #include <dlfcn.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/deep_stack_uaf.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/deep_stack_uaf.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/deep_stack_uaf.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/deep_stack_uaf.cc Thu May 29 18:34:47 2014
> @@ -2,6 +2,7 @@
>
>  // RUN: %clangxx_asan -O0 %s -o %t 2>&1
>  // RUN: env ASAN_OPTIONS=malloc_context_size=120:redzone=512 not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>  #include <stdlib.h>
>  #include <stdio.h>
>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/double-free.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/double-free.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/double-free.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/double-free.cc Thu May 29 18:34:47 2014
> @@ -4,6 +4,7 @@
>  // Also works if no malloc context is available.
>  // RUN: env ASAN_OPTIONS=malloc_context_size=0:fast_unwind_on_malloc=0 not %run %t 2>&1 | FileCheck %s
>  // RUN: env ASAN_OPTIONS=malloc_context_size=0:fast_unwind_on_malloc=1 not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #include <stdlib.h>
>  #include <string.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/gc-test.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/gc-test.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/gc-test.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/gc-test.cc Thu May 29 18:34:47 2014
> @@ -1,6 +1,7 @@
>  // RUN: %clangxx_asan %s -pthread -o %t
>  // RUN: env ASAN_OPTIONS=detect_stack_use_after_return=1 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1
>  // RUN: env ASAN_OPTIONS=detect_stack_use_after_return=0 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
> +// XFAIL: arm
>
>  #include <assert.h>
>  #include <stdio.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/invalid-free.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/invalid-free.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/invalid-free.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/invalid-free.cc Thu May 29 18:34:47 2014
> @@ -4,6 +4,7 @@
>  // Also works if no malloc context is available.
>  // RUN: env ASAN_OPTIONS=malloc_context_size=0:fast_unwind_on_malloc=0 not %run %t 2>&1 | FileCheck %s
>  // RUN: env ASAN_OPTIONS=malloc_context_size=0:fast_unwind_on_malloc=1 not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #include <stdlib.h>
>  #include <string.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/large_func_test.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/large_func_test.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/large_func_test.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/large_func_test.cc Thu May 29 18:34:47 2014
> @@ -2,6 +2,7 @@
>  // RUN: %clangxx_asan -O1 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O2 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O3 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
> +// XFAIL: arm
>
>  #include <stdlib.h>
>  __attribute__((noinline))
>
> Modified: compiler-rt/trunk/test/asan/TestCases/mmap_limit_mb.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/mmap_limit_mb.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/mmap_limit_mb.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/mmap_limit_mb.cc Thu May 29 18:34:47 2014
> @@ -7,6 +7,7 @@
>  // RUN: env ASAN_OPTIONS=mmap_limit_mb=500 %run %t 50 1000000
>  // RUN: env ASAN_OPTIONS=mmap_limit_mb=500 not %run %t 500 16 2>&1 | FileCheck %s
>  // RUN: env ASAN_OPTIONS=mmap_limit_mb=500 not %run %t 500 1000000 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #include <assert.h>
>  #include <stdlib.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/sanity_check_pure_c.c
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/sanity_check_pure_c.c?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/sanity_check_pure_c.c (original)
> +++ compiler-rt/trunk/test/asan/TestCases/sanity_check_pure_c.c Thu May 29 18:34:47 2014
> @@ -5,6 +5,7 @@
>  // Sanity checking a test in pure C with -pie.
>  // RUN: %clang_asan -O2 %s -pie -fPIE -o %t
>  // RUN: not %run %t 2>&1 | FileCheck %s
> +// XFAIL: arm
>
>  #include <stdlib.h>
>  int main() {
>
> Modified: compiler-rt/trunk/test/asan/TestCases/strncpy-overflow.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/strncpy-overflow.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/strncpy-overflow.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/strncpy-overflow.cc Thu May 29 18:34:47 2014
> @@ -4,6 +4,7 @@
>  // RUN: %clangxx_asan -O3 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>
>  // REQUIRES: compiler-rt-optimized
> +// XFAIL: arm
>
>  #include <string.h>
>  #include <stdlib.h>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/use-after-delete.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/use-after-delete.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/use-after-delete.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/use-after-delete.cc Thu May 29 18:34:47 2014
> @@ -2,6 +2,7 @@
>  // RUN: %clangxx_asan -O1 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O2 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O3 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
> +// XFAIL: arm
>
>  #include <stdlib.h>
>  int main() {
>
> Modified: compiler-rt/trunk/test/asan/TestCases/use-after-free-right.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/use-after-free-right.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/use-after-free-right.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/use-after-free-right.cc Thu May 29 18:34:47 2014
> @@ -2,6 +2,7 @@
>  // RUN: %clangxx_asan -O1 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O2 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O3 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
> +// XFAIL: arm
>
>  // Test use-after-free report in the case when access is at the right border of
>  // the allocation.
>
> Modified: compiler-rt/trunk/test/asan/TestCases/use-after-free.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/use-after-free.cc?rev=209862&r1=209861&r2=209862&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/use-after-free.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/use-after-free.cc Thu May 29 18:34:47 2014
> @@ -2,6 +2,7 @@
>  // RUN: %clangxx_asan -O1 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O2 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
>  // RUN: %clangxx_asan -O3 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
> +// XFAIL: arm
>
>  #include <stdlib.h>
>  int main() {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list