[llvm] r210228 - DebugInfo: Add comments/assert description to r209674 based on Eric Christopher's post-commit review feedback.

David Blaikie dblaikie at gmail.com
Wed Jun 4 17:25:26 PDT 2014


Author: dblaikie
Date: Wed Jun  4 19:25:26 2014
New Revision: 210228

URL: http://llvm.org/viewvc/llvm-project?rev=210228&view=rev
Log:
DebugInfo: Add comments/assert description to r209674 based on Eric Christopher's post-commit review feedback.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=210228&r1=210227&r2=210228&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Wed Jun  4 19:25:26 2014
@@ -1389,7 +1389,7 @@ DIE *DwarfUnit::getOrCreateSubprogramDIE
   // DW_TAG_inlined_subroutine may refer to this DIE.
   DIE &SPDie = createAndAddDIE(dwarf::DW_TAG_subprogram, *ContextDIE, SP);
 
-  // Abort here and fill this in later, depending on whether or not this
+  // Stop here and fill this in later, depending on whether or not this
   // subprogram turns out to have inlined instances or not.
   if (SP.isDefinition())
     return &SPDie;
@@ -1403,7 +1403,9 @@ void DwarfUnit::applySubprogramAttribute
   StringRef DeclLinkageName;
   if (DISubprogram SPDecl = SP.getFunctionDeclaration()) {
     DeclDie = getDIE(SPDecl);
-    assert(DeclDie);
+    assert(DeclDie && "This DIE should've already been constructed when the "
+                      "definition DIE was creaeted in "
+                      "getOrCreateSubprogramDIE");
     DeclLinkageName = SPDecl.getLinkageName();
   }
 





More information about the llvm-commits mailing list