[PATCH][CMake] Add target to generate td file with all records

Adam Nemet anemet at apple.com
Wed Jun 4 10:16:14 PDT 2014


Hi Chandler,

Do you have any more comments, or v2 of the patch is OK to go?

Thanks,
Adam

On May 30, 2014, at 10:47 AM, Adam Nemet <anemet at apple.com> wrote:

> Just a bit more info on this.  It adds an expand-<td-file-name> target which then generates <td-file-name>.expanded.
> 
> I wasn’t able to get away with the expand-td target as before because targets have to be globally unique in cmake.
> 
> Adam
> 
> On May 30, 2014, at 12:59 AM, Adam Nemet <anemet at apple.com> wrote:
> 
>> Thanks for taking a look.  Is this more or less of what you had in mind?
>> 
>> Adam
>> 	
>> On May 29, 2014, at 6:56 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> 
>>> Seems fine. Do you want to sink this into the tablegen thing itself? Also, a nice to have would be to prevent people from depending on this... not sure how though.
>>> 
>>> 
>>> On Thu, May 29, 2014 at 6:19 PM, Adam Nemet <anemet at apple.com> wrote:
>>> This is the cmake version of r208056 that was requested by James Molloy.  For
>>> now I only added X86 for the sake of the review.  I'll add the rest as obvious
>>> later.
>>> 
>>> This is the closest I could get to the make version.  I didn't want
>>> td.expanded to be generate by default, so I added a new target for it.  Looks
>>> like that there is no way to simply have the file name match the rule with
>>> add_custom_target as in make (you'd need add_executable or add_library for
>>> that).
>>> 
>>> Please let me know if this looks good.
>>> 
>>> Thanks,
>>> Adam
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>> 
>>> 
> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140604/f5f24ef9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CMake-Add-target-to-generate-td-file-with-all-record-v2.patch
Type: application/octet-stream
Size: 3336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140604/f5f24ef9/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140604/f5f24ef9/attachment-0001.html>


More information about the llvm-commits mailing list