[PATCH] [InstCombine] Canonicalize addrspacecast between different element types

Matt Arsenault Matthew.Arsenault at amd.com
Tue Jun 3 18:48:58 PDT 2014


LGTM

================
Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:1925-1926
@@ +1924,4 @@
+
+    // Putting bitcast before addrspacecast helps NVPTXFavorNonGenericAddrSpaces
+    // to fold the addrspacecast into load/store.
+    Value *NewBitCast = Builder->CreateBitCast(Src, MidTy);
----------------
I would remove  the comment about a specific target pass

http://reviews.llvm.org/D4013






More information about the llvm-commits mailing list