[PATCH] R600/SI: SI Control Flow Annotation bug fixed

Matt Arsenault Matthew.Arsenault at amd.com
Tue Jun 3 14:45:00 PDT 2014


On 06/03/2014 02:16 AM, Christian König wrote:
> Am 03.06.2014 10:59, schrieb Matt Arsenault:
>> On Jun 3, 2014, at 1:46 AM, Елена Денисова <denisova.lena at gmail.com> 
>> wrote:
>>
>>> <0001-SI-Control-Flow-Annotation-bug-fix.patch>
>> Needs a test
>
> The control flow leading to this issue is rather complicated, and 
> because of this I'm not sure if we want to have a test case for it 
> cause it would break quite often on completely unrelated changes.
>
> On the other hand I know that Lena doesn't have an environment to run 
> piglit tests with this, so somebody (Tim, Matt?) should do this to 
> make sure we don't break anything there.
>
> Either way the patch itself looks good to me and is Reviewed-by: 
> Christian König <christian.koenig at amd.com>
>
> Regards,
> Christian.


I think it would be useful to include something, even if the checks are 
really relaxed. It's unfortunate that there aren't really any moderately 
complex control flow testcases now. I can probably try running piglit on 
this tomorrow (although for me ~20 tests are failing already on trunk. 
Are those currently expected?)

-Matt




More information about the llvm-commits mailing list