[lld] r210089 - Rename FileToMutable -> SimpleFileWrapper.

Rui Ueyama ruiu at google.com
Tue Jun 3 01:12:33 PDT 2014


Author: ruiu
Date: Tue Jun  3 03:12:33 2014
New Revision: 210089

URL: http://llvm.org/viewvc/llvm-project?rev=210089&view=rev
Log:
Rename FileToMutable -> SimpleFileWrapper.

FileToMutable is what this class does, but this class (or, to be precise,
an instance of this class) is a wrapper of the other SimpleFile. It's odd
that the class was named like a function.

Modified:
    lld/trunk/include/lld/ReaderWriter/Simple.h
    lld/trunk/lib/Passes/RoundTripNativePass.cpp
    lld/trunk/lib/Passes/RoundTripYAMLPass.cpp

Modified: lld/trunk/include/lld/ReaderWriter/Simple.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/Simple.h?rev=210089&r1=210088&r2=210089&view=diff
==============================================================================
--- lld/trunk/include/lld/ReaderWriter/Simple.h (original)
+++ lld/trunk/include/lld/ReaderWriter/Simple.h Tue Jun  3 03:12:33 2014
@@ -66,9 +66,9 @@ protected:
   atom_collection_vector<AbsoluteAtom>       _absoluteAtoms;
 };
 
-class FileToMutable : public SimpleFile {
+class SimpleFileWrapper : public SimpleFile {
 public:
-  FileToMutable(const LinkingContext &context, const File &file)
+  SimpleFileWrapper(const LinkingContext &context, const File &file)
       : SimpleFile(file.path()) {
     for (auto definedAtom : file.defined())
       _definedAtoms._atoms.push_back(std::move(definedAtom));

Modified: lld/trunk/lib/Passes/RoundTripNativePass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Passes/RoundTripNativePass.cpp?rev=210089&r1=210088&r2=210089&view=diff
==============================================================================
--- lld/trunk/lib/Passes/RoundTripNativePass.cpp (original)
+++ lld/trunk/lib/Passes/RoundTripNativePass.cpp Tue Jun  3 03:12:33 2014
@@ -47,7 +47,7 @@ void RoundTripNativePass::perform(std::u
     llvm_unreachable("native reader not registered or read error");
   }
   File *objFile = _nativeFile[0].get();
-  mergedFile.reset(new FileToMutable(_context, *objFile));
+  mergedFile.reset(new SimpleFileWrapper(_context, *objFile));
 
   llvm::sys::fs::remove(tmpNativeFile.str());
 }

Modified: lld/trunk/lib/Passes/RoundTripYAMLPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Passes/RoundTripYAMLPass.cpp?rev=210089&r1=210088&r2=210089&view=diff
==============================================================================
--- lld/trunk/lib/Passes/RoundTripYAMLPass.cpp (original)
+++ lld/trunk/lib/Passes/RoundTripYAMLPass.cpp Tue Jun  3 03:12:33 2014
@@ -46,6 +46,6 @@ void RoundTripYAMLPass::perform(std::uni
     llvm_unreachable("yaml reader not registered or read error");
   }
   File *objFile = _yamlFile[0].get();
-  mergedFile.reset(new FileToMutable(_context, *objFile));
+  mergedFile.reset(new SimpleFileWrapper(_context, *objFile));
   llvm::sys::fs::remove(tmpYAMLFile.str());
 }





More information about the llvm-commits mailing list