[PATCH] [PECOFF] Support COMDAT associative sections.

[Rui Ueyama]

On Thu, May 29, 2014 at 5:03 AM, Simon Atanasyan <simon at atanasyan.com>
wrote:

> LGTM with minor question / note.
>
> ================
> Comment at: lib/ReaderWriter/PECOFF/ReaderCOFF.cpp:174
> @@ +173,3 @@
> +  // COMDAT associative sections
> +  std::map<const coff_section *, std::set<const coff_section *>>
> _association;
> +
> ----------------
> Is it really necessary to use the `std::set` here i.e. is it possible that
> a COFF file contains more than one "record" states that sections say "A"
> and "B" are associated?
>

I have never seen such complicated object file, and but my understanding of
the spec is that such thing is allowed.

http://reviews.llvm.org/D3946
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140529/a2fca768/attachment.html>