[PATCH] Convert a vselect into a concat_vector if possible

[Filipe Cabecinhas]

Fixed a bug pointed by Hal Finkel, when returning the new concat_vectors

The code was doing the exact opposite of what it should.
I also added the specific registers to the test, in a way that accounts for some order change from the instruction scheduling.

I'm having a problem in making this test generic, though. Should I do a test for some additional architectures? The test/CodeGen/Generic directory only seems to check that llc doesn't error out when running on it. But I see no way to test this optimization without actually looking at the code.

Should I do more tests? Any way to check this that I didn't think about?

Thanks,

- Filipe

http://reviews.llvm.org/D3916

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/Generic/select.ll
  test/CodeGen/X86/vselect.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3916.9902.patch
Type: text/x-patch
Size: 4452 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140529/a8f97875/attachment.bin>