[PATCH] Convert a vselect into a concat_vector if possible

hfinkel at anl.gov hfinkel at anl.gov
Wed May 28 00:43:19 PDT 2014


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4634
@@ +4633,3 @@
+         "One half of the selector was all UNDEFs and the other was all the "
+         "same value. This should have been addressed before this function.");
+  return DAG.getNode(
----------------
Are you sure this is always true on all possible code paths? If you are sure, please add a comment explaining where this is handled and why it will always happen first. Otherwise, please just make this a normal check.

http://reviews.llvm.org/D3916






More information about the llvm-commits mailing list