[PATCH] Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads

Raul Silvera rsilvera at google.com
Tue May 27 22:21:16 PDT 2014


Karthik, I do not have any objections to this patch. I think longer term we
should try to pursue the other cases but this is a good short-term step.

I'll let others provide their approval.

Raúl E Silvera | SWE | rsilvera at google.com | *408-789-2846*



On Tue, May 27, 2014 at 9:12 PM, Karthik Bhat <kv.bhat at samsung.com> wrote:

> Hi Nadav,
> Please find the performance result with and without patch. I dont see
> large regression in compilation time though execution time of one test case
> improved greatly. The baseline is without patch and current is with patch.
>
> {F60858}
>
> Hi Raul,Arnold
> I agree that the current patch will not handle the case mentioned. I was
> thinking of handling unschedulable loads again after buildTree_rec was
> completed but as arnold mentioned i'm not sure if this would be worth the
> ovehead.
>
> For now do you think we can move ahead with this approach as we are able
> to vectorize loads similar to one's mentioned in the PR without much
> overhead?
>
> Thanks  for all the comments and review.
>
> Regards
> Karthik Bhat
>
> http://reviews.llvm.org/D3800
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140527/57f8f2c6/attachment.html>


More information about the llvm-commits mailing list