[ppc][patch] Use alias symbols in address computation

Bill Schmidt wschmidt at linux.vnet.ibm.com
Mon May 26 12:13:32 PDT 2014


Hi Rafael,

This LGTM.  I wrote the original too-complex code here, and IIRC AI
thought the looking-through-aliases was necessary to be able to use
hasInitializer() without error.  But I was unaware of the proper
interface (isDeclaration()) that simplifies this and allows proper
referencing of the aliases where appropriate.  Assuming there are no
test regressions, this looks good.

Thanks,
Bill

On Mon, 2014-05-26 at 13:31 -0500, Hal Finkel wrote:
> Bill,
> 
> Can you please look at this?
> 
>  -Hal
> 
> ----- Original Message -----
> > From: "Rafael EspĂ­ndola" <rafael.espindola at gmail.com>
> > To: "llvm-commits" <llvm-commits at cs.uiuc.edu>
> > Cc: "Hal Finkel" <hfinkel at anl.gov>
> > Sent: Monday, May 26, 2014 12:04:40 PM
> > Subject: Re: [ppc][patch] Use alias symbols in address computation
> > 
> > Sorry, I attached an old patch.
> > 
> > Complete patch attached.
> > 
> > On 26 May 2014 12:57, Rafael EspĂ­ndola <rafael.espindola at gmail.com>
> > wrote:
> > > This seems to match what gcc does for ppc and what every other llvm
> > > backend does.
> > >
> > > Cheers,
> > > Rafael
> > 
> 




More information about the llvm-commits mailing list