[PATCH] [MSan] Implement __sanitizer_print_stack_trace().

Evgeniy Stepanov eugenis at google.com
Mon May 26 05:36:18 PDT 2014


LGTM w/ nit

================
Comment at: test/msan/print-stack-trace.cc:1
@@ +1,2 @@
+// RUN: %clangxx_msan -O0 %s -o %t && %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_msan -O3 %s -o %t && %run %t 2>&1 | FileCheck %s
----------------
Alexey Samsonov wrote:
> This test should go to test/sanitizer_common/TestCases (and remove the same test case from ASan suite).
And when you do that, beware that on Mac (I think) stack trace line for main may have () after the function name. Or maybe not. Anyway, it's better to remove the space after main and before .*

http://reviews.llvm.org/D3899






More information about the llvm-commits mailing list