[PATCH] Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads

Nadav Rotem nrotem at apple.com
Fri May 23 09:32:19 PDT 2014


Hi Karthik, 

Can you please measure the effects of this patch on the LLVM test suite?  It would be interesting to see if other workloads are affected by this change and if they improve or regress.

Thanks,
Nadav


On May 23, 2014, at 1:48 AM, Karthik Bhat <kv.bhat at samsung.com> wrote:

> Hi Arnold,Nadav,Raul,
> Thanks for the review. Using basic block numbering to decide which subtree to process seems to work in these cases. A larger subtree will have larger getLastIndex we can use the same to decide which subtree to process first. Updated the patch accordingly.
> Does this approach look good?
> I am still relatively new to this module so thanks for the patience and clarifications.
> Regards
> Karthik Bhat
> 
> http://reviews.llvm.org/D3800
> 
> Files:
>  lib/Transforms/Vectorize/SLPVectorizer.cpp
>  test/Transforms/SLPVectorizer/X86/pr19657.ll
> <D3800.9742.patch>




More information about the llvm-commits mailing list