[llvm] r209496 - MC: remove unnecessary restriction on tests

Saleem Abdulrasool compnerd at compnerd.org
Thu May 22 19:56:51 PDT 2014


Author: compnerd
Date: Thu May 22 21:56:51 2014
New Revision: 209496

URL: http://llvm.org/viewvc/llvm-project?rev=209496&view=rev
Log:
MC: remove unnecessary restriction on tests

Rafael correctly pointed out that the restriction is unnecessary.  Although the
tests are intended to ensure that we dont abort due to an assertion, running the
tests in all modes is better since it also ensures that we dont crash without
assertions.  Always run these tests to ensure that we can handle invalid input
correctly.

Modified:
    llvm/trunk/test/MC/AsmParser/invalid-input-assertion.s
    llvm/trunk/test/MC/COFF/invalid-def.s
    llvm/trunk/test/MC/COFF/invalid-endef.s
    llvm/trunk/test/MC/COFF/invalid-scl-range.s
    llvm/trunk/test/MC/COFF/invalid-scl.s
    llvm/trunk/test/MC/COFF/invalid-type-range.s
    llvm/trunk/test/MC/COFF/invalid-type.s

Modified: llvm/trunk/test/MC/AsmParser/invalid-input-assertion.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/invalid-input-assertion.s?rev=209496&r1=209495&r2=209496&view=diff
==============================================================================
--- llvm/trunk/test/MC/AsmParser/invalid-input-assertion.s (original)
+++ llvm/trunk/test/MC/AsmParser/invalid-input-assertion.s Thu May 22 21:56:51 2014
@@ -1,5 +1,4 @@
 // RUN: not llvm-mc -triple i686-linux -o /dev/null %s
-// REQUIRES: asserts
 
 	.macro macro parameter=0
 		.if \parameter

Modified: llvm/trunk/test/MC/COFF/invalid-def.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/invalid-def.s?rev=209496&r1=209495&r2=209496&view=diff
==============================================================================
--- llvm/trunk/test/MC/COFF/invalid-def.s (original)
+++ llvm/trunk/test/MC/COFF/invalid-def.s Thu May 22 21:56:51 2014
@@ -1,5 +1,4 @@
 # RUN: not llvm-mc -triple i686-windows -filetype obj -o /dev/null %s
-# REQUIRES: asserts
 
 	.def first
 	.def second

Modified: llvm/trunk/test/MC/COFF/invalid-endef.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/invalid-endef.s?rev=209496&r1=209495&r2=209496&view=diff
==============================================================================
--- llvm/trunk/test/MC/COFF/invalid-endef.s (original)
+++ llvm/trunk/test/MC/COFF/invalid-endef.s Thu May 22 21:56:51 2014
@@ -1,5 +1,4 @@
 # RUN: not llvm-mc -triple i686-windows -filetype obj -o /dev/null %s
-# REQUIRES: asserts
 
 	.endef
 

Modified: llvm/trunk/test/MC/COFF/invalid-scl-range.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/invalid-scl-range.s?rev=209496&r1=209495&r2=209496&view=diff
==============================================================================
--- llvm/trunk/test/MC/COFF/invalid-scl-range.s (original)
+++ llvm/trunk/test/MC/COFF/invalid-scl-range.s Thu May 22 21:56:51 2014
@@ -1,5 +1,4 @@
 # RUN: not llvm-mc -triple i686-windows -filetype obj -o /dev/null %s
-# REQUIRES: asserts
 
 	.def storage_class_range
 		.scl 1337

Modified: llvm/trunk/test/MC/COFF/invalid-scl.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/invalid-scl.s?rev=209496&r1=209495&r2=209496&view=diff
==============================================================================
--- llvm/trunk/test/MC/COFF/invalid-scl.s (original)
+++ llvm/trunk/test/MC/COFF/invalid-scl.s Thu May 22 21:56:51 2014
@@ -1,5 +1,4 @@
 # RUN: not llvm-mc -triple i686-windows -filetype obj -o /dev/null %s
-# REQUIRES: asserts
 
 	.scl 1337
 

Modified: llvm/trunk/test/MC/COFF/invalid-type-range.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/invalid-type-range.s?rev=209496&r1=209495&r2=209496&view=diff
==============================================================================
--- llvm/trunk/test/MC/COFF/invalid-type-range.s (original)
+++ llvm/trunk/test/MC/COFF/invalid-type-range.s Thu May 22 21:56:51 2014
@@ -1,5 +1,4 @@
 # RUN: not llvm-mc -triple i686-windows -filetype obj -o /dev/null %s
-# REQUIRES: asserts
 
 	.def invalid_type_range
 		.type 65536

Modified: llvm/trunk/test/MC/COFF/invalid-type.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/invalid-type.s?rev=209496&r1=209495&r2=209496&view=diff
==============================================================================
--- llvm/trunk/test/MC/COFF/invalid-type.s (original)
+++ llvm/trunk/test/MC/COFF/invalid-type.s Thu May 22 21:56:51 2014
@@ -1,5 +1,4 @@
 # RUN: not llvm-mc -triple i686-windows -filetype obj -o /dev/null %s
-# REQUIRES: asserts
 
 	.type 65536
 





More information about the llvm-commits mailing list