[PATCH] Add support for missed and analysis optimization remarks.

Diego Novillo dnovillo at google.com
Thu May 22 07:28:01 PDT 2014


On Wed, May 21, 2014 at 6:45 PM, Quentin Colombet <qcolombet at apple.com>wrote:

> Hi Diego,
>
> Thanks for the diff, I was wondering where some of the changes came from
> :).
>
> This LGTM.
>
> One remark, would it be possible to move the PassRemarkXXX options and
> related implementation in the DiagnosticInfo implementation too?
> I.e., stuff related to static cl::opt<PassRemarksOpt, etc.
>
> If it is possible, you can fix that in a subsequent commit, if it is not I
> can live with that :).
>

Thanks. Yeah, I think they're movable. I've committed this version and will
send you a new patch that moves them shortly.


Diego.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140522/972fe356/attachment.html>


More information about the llvm-commits mailing list