[PATCH] Generalize stackdepot.

Evgeniy Stepanov eugenis at google.com
Wed May 21 02:01:36 PDT 2014


================
Comment at: lib/msan/msan.cc:566
@@ -519,1 +565,3 @@
+    bool inserted = ChainedOriginDepotPut(idx, Origin::kStackRoot, &id);
+    CHECK(inserted); // All first time stack origins are unique.
     *id_ptr = id;
----------------
Dmitry Vyukov wrote:
> Evgeniy Stepanov wrote:
> > Dmitry Vyukov wrote:
> > > Isn't it subject to races? What if two threads trigger this alloca for the first time?
> > Yeah, we may have duplicate entries for stack origins.
> > 
> Then remove the CHECK.
done

http://reviews.llvm.org/D3790






More information about the llvm-commits mailing list