[PATCH 5/5] [asan] Avoid shift count overflow in CanBeAHeapPointer

Kostya Serebryany kcc at google.com
Wed May 21 01:41:11 PDT 2014


Hmmm.
Did you use lsan on x32, or you just tried to build it?
I afraid, lsan is not going to work on x32 properly, even if it may *appear
to work* on small cases.
See e.g. https://code.google.com/p/address-sanitizer/issues/detail?id=294#c5
So, r209283 disables lsan if wordsize != 64.

If you want to enable lsan on x32, let this be a separate effort.

--kcc


On Tue, May 20, 2014 at 10:37 PM, H.J. Lu <hjl.tools at gmail.com> wrote:

> This patch checks _LP64 and _WIN64 in addition to __x86_64__ before
> right shifting a pointer by 47.
>
> --
> H.J.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140521/fe5416f8/attachment.html>


More information about the llvm-commits mailing list