[PATCH] Allow external projects to run tests via llvm-lit

Alp Toker alp at nuanti.com
Tue May 20 17:51:23 PDT 2014


LGTM.

Please keep an eye on the build bots after landing, and be ready for a 
post-commit review from CMake regulars when they get back(!)

Cheers
Alp.

On 21/05/2014 03:42, Greg Fitzgerald wrote:
> test if variable is set instead of testing if directory exists
>
> http://reviews.llvm.org/D3429
>
> Files:
>    cmake/modules/AddLLVM.cmake
>
> Index: cmake/modules/AddLLVM.cmake
> ===================================================================
> --- cmake/modules/AddLLVM.cmake
> +++ cmake/modules/AddLLVM.cmake
> @@ -632,11 +632,12 @@
>     if (NOT CMAKE_CFG_INTDIR STREQUAL ".")
>       list(APPEND LIT_ARGS --param build_mode=${CMAKE_CFG_INTDIR})
>     endif ()
> -  set(LIT_COMMAND
> -    ${PYTHON_EXECUTABLE}
> -    ${LLVM_MAIN_SRC_DIR}/utils/lit/lit.py
> -    ${LIT_ARGS}
> -    )
> +  if (LLVM_MAIN_SRC_DIR)
> +    set (LIT_COMMAND ${PYTHON_EXECUTABLE} ${LLVM_MAIN_SRC_DIR}/utils/lit/lit.py)
> +  else()
> +    find_program(LIT_COMMAND llvm-lit)
> +  endif ()
> +  list(APPEND LIT_COMMAND ${LIT_ARGS})
>     foreach(param ${ARG_PARAMS})
>       list(APPEND LIT_COMMAND --param ${param})
>     endforeach()
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list