[patch][pr10367] Add support for offsets in GlobalAlias

[Reid Kleckner]

So, it's a bit late, but why *exactly* is it better to use an offset than a
constant GEP?

I remember asking this question before, but I don't remember the answer.  I
can't find it in my inbox either.

On Tue, May 20, 2014 at 3:28 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> > I think you should explicitly state that the offset is in bytes.
>
> Good idea. Fixed.
>
> >> +  const APSInt &Val = Lex.getAPSIntVal();
> >> +  if (Val.getBitWidth() > 64)
> >> +    return TokError("expected a 64 bit unsegned integer");
> >
> > s/unsegned/unsigned
>
> Oh, on the current patch the offset is signed. I just forgot to update
> the error message. I fixed it in the attached version.
>
> Thanks,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140520/63e7d296/attachment.html>