[lld] r208365 - [PECOFF] Split LocallyImportedSymbolFile into two classes.

[Simon Atanasyan]

Hi Rui,

On Fri, May 9, 2014 at 2:30 AM, Rui Ueyama <ruiu at google.com> wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=208365&view=rev

[...]

> +class VirtualArchiveLibraryFile : public ArchiveLibraryFile {
> +public:
> +  VirtualArchiveLibraryFile(StringRef filename)
> +      : ArchiveLibraryFile(filename) {}

Just curious, what intention is to put VirtualArchiveLibraryFile into
the anonymous namespace and later use it as a base class for globally
visible class LocallyImportedSymbolFile? By the way this triggers the
following gcc warning:

[[
LinkerGeneratedSymbolFile.h:143:7: warning:
‘lld::pecoff::LocallyImportedSymbolFile’ has a field
‘lld::pecoff::LocallyImportedSymbolFile::<anonymous>’ whose type uses
the anonymous namespace ...
]]

[...]

> -class LocallyImportedSymbolFile : public ArchiveLibraryFile {
> +class LocallyImportedSymbolFile : public VirtualArchiveLibraryFile {

-- 
Simon