PATCH: R600/SI: Tablegen refactoring

Matt Arsenault arsenm2 at
Fri May 16 10:11:52 PDT 2014

On May 16, 2014, at 8:17 AM, Tom Stellard <tom at> wrote:

> Hi,
> The attached patches refactor the SI tablegen definitions to enable to
> allow for some convenient simplifications in the future.
> -Tom

LGTM. For the 4th one, why can’t the pattern be specified on the instruction directly? Is the extra 0 operand to the instruction a problem? I also don’t understand the point of the 6th one. Which instructions have different encodings on different subtargets?

More information about the llvm-commits mailing list