[PATCH] [sanitizer] Support sandboxing in sanitizer coverage.

Reid Kleckner rnk at google.com
Fri May 16 10:01:26 PDT 2014

Comment at: include/sanitizer/common_interface_defs.h:29
@@ +28,3 @@
+    int coverage_sandboxed;
+    int coverage_fd;
+    size_t coverage_max_block_size;
Sergey Matveev wrote:
> Kostya Serebryany wrote:
> > I wonder how this is going to work on Windows
> It's hard to speculate in the absense of any users of __sanitizer_sandbox_on_notify() on Windows.
I think we are going to need it, and it will probably look similar, except this will be a HANDLE (aka void*) instead of an int.

When you add Windows support, you could do #ifdef WIN32 to avoid breaking ABI on Linux, but it might be better to use a uptr instead of an int to make it the same.


More information about the llvm-commits mailing list