[PATCH] Fix fastcc/tailcallopt for ARM64
liujiangning1 at gmail.com
Wed May 14 18:59:35 PDT 2014
Modified as you suggested and committed as r208837.
2014-05-14 16:17 GMT+08:00 Tim Northover <t.p.northover at gmail.com>:
> Hi Jiangning,
> Sorry for the delay, I somehow missed the fact that you'd updated the
> patch. And then I somehow managed to close the tab I was doing the review
> Anyway, I've just got a comment on a couple of asserts which probably need
> adjusting for ARM64. Other than that it looks fine to me. No need to post
> another version, I don't think.
> Comment at: lib/Target/ARM64/ARM64FrameLowering.cpp:134
> @@ +133,3 @@
> + // it is a limitation that needs dealing with.
> + assert(Amount > -0xfff && Amount < 0xfff && "call frame too large");
> + emitFrameOffset(MBB, I, DL, ARM64::SP, ARM64::SP, Amount, TII);
> It looks like ARM64's emitFrameOffset can handle larger immediates (up to
> 24 bits easily, beyond that inefficiently). Same thing later.
More information about the llvm-commits