Platform-specific RUN lines in lit tests?
timurrrr at google.com
Wed May 14 13:24:11 PDT 2014
2014-05-15 0:14 GMT+04:00 Reid Kleckner <rnk at google.com>:
> On Wed, May 14, 2014 at 12:18 PM, Robinson, Paul <
> Paul_Robinson at playstation.sony.com> wrote:
>> > > > - Use a macro for "-x c" / "/TC" (sounds like an overkill for just
>> > > > test?)
>> > > This seems like an annoying thing to deal with - is it particularly
>> > > useful to test the clang-cl driver rather than just using the normal
>> > > clang gcc-like driver?
>> > Currently we have to use clang-cl as the default compiler to build tests
>> > since we fall back on a few TUs (most notably gtest).
>> > Also, I'd argue that a significant (prevailing?) portion of the ASan
>> > on Windows will use clang-cl driver, so we want it to have the
>> > support and test coverage.
>> Are these hacks specific to ASan or more general?
>> "hosted on Windows" != "using clang-cl driver"
>> (not for us, anyway, and we have no plan to switch to clang-cl)
> What do you find hack-ish?
I mean the "one lit tests takes another as an input" approach.
> I think we should continue to support the default, gcc-compatible clang
> driver on Windows.
> We should also expose ASan functionality through clang-cl, since it's a
> major feature that somebody might want to use.
> IMO we should make the ASan test suite pass on Windows with both clang.exe
> and clang-cl.exe.
> I think we can tolerate a few corner cases where we don't want to add
> flags to clang-cl with lit substitutions. For example, "-x c" vs. "/TC".
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits