[patch][PR10367] Fix the design of GlobalAlias v2

Reid Kleckner rnk at google.com
Wed May 14 13:00:14 PDT 2014


Looks good, but I'd let Duncan comment.

There is an instance of "Aliassee" in clang-3.patch that should probably be
made consistent with the rest.


On Wed, May 14, 2014 at 12:08 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> Starting a new thread to get a fresh view of the state of the patches.
>
> The introduction of GlobalObject was already committed. These patches are
> * rebased on top of trunk.
> * include the feedback from the previous code review. Let me know if I
> missed anything.
> * Splits the manual removal of getAliasedGlobal to a separate patch.
> * Includes some linker fixes I found while rereading the previous version.
>
> One thing that I noticed with the discussion about the C api is that
> LLVMAddAlias should probably not be changed, even if the constructor
> of GlobalAlias is changed. I will try to split this into an
> independent patch.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140514/1cf1d445/attachment.html>


More information about the llvm-commits mailing list