[PATCH] Fix regression introduced in r205566.

Rui Ueyama ruiu at google.com
Tue May 13 12:20:53 PDT 2014

Comment at: lib/Core/Resolver.cpp:66-68
@@ -69,1 +65,5 @@
+  llvm::dbgs() << "undefAdded: " << undefAdded << "\n";
+  if (undefAdded) {
+    _context.getInputGraph().notifyProgress();
+  }
Shankar Kalpathi Easwaran wrote:
> it looks like notifyProgress is called only if there is a undefined atom added, can we do it in doUndefinedAtom ? This way there would be no need to change much.
I don't want to call notifyProgress in doUndefinedAtom. If we do, notifyProgress() would be called for each undefined atom. That's not wrong but would be slow. I want call it only once.


More information about the llvm-commits mailing list