[PATCH] Legalize SetCC needs logical NOT
peter_cooper at apple.com
Mon May 12 15:25:14 PDT 2014
Please review this patch to use a logical not when inverting a SetCC.
The problem is that if I have something like
i8 = setcc
then using an xor with 0xFF will give the wrong answer when the boolean contents are ZeroOrOne.
Unfortunately I couldn’t find a single target which goes wrong here so I can’t generate a test case. Putting ‘llvm_unreachable’ in here just doesn’t hit, but hopefully its clear from the patch that there’s an obvious issue.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2345 bytes
Desc: not available
More information about the llvm-commits