[llvm] r208228 - [yaml2obj] Support ELF x86 relocations.

Simon Atanasyan simon at atanasyan.com
Fri May 9 07:08:58 PDT 2014


On Fri, May 9, 2014 at 3:32 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> 2014-05-08 2:06 GMT+09:00 Simon Atanasyan <simon at atanasyan.com>:
>> Author: atanasyan
>> Date: Wed May  7 12:06:38 2014
>> New Revision: 208228
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=208228&view=rev
>> Log:
>> [yaml2obj] Support ELF x86 relocations.

[...]

>> +Sections:
>> +  - Type:            SHT_PROGBITS
>> +    Name:            .text
>> +    Type:            SHT_PROGBITS
>
> 2nd hash "Type" causes memory leak.
>
> YAMLTraits.cpp:343: mapHNode->Mapping[KeyStr] = ValueHNode;
>
> Previous value of Mapping[KeyStr] lost.
> Tweaked in r208406. Could you fix?

I fixed the test case at r208412. I will take a look at the YAMLTraits
code a bit later.

-- 
Simon



More information about the llvm-commits mailing list