[llvm] r208148 - llvm-cov: Implement --no-output
rnk at google.com
Thu May 8 17:41:43 PDT 2014
On Wed, May 7, 2014 at 9:12 AM, Justin Bogner <mail at justinbogner.com> wrote:
> David Blaikie <dblaikie at gmail.com> writes:
> > On Wed, May 7, 2014 at 2:00 AM, Timur Iskhodzhanov <timurrrr at google.com>
> >> I've worked around that in r208171.
> >> Please take a look and come up with a more permanent fix.
> > This is essentially the semi-permanent fix (Justin can just remove the
> > comment). Reid's done this in other places for the same reason.
> > One discussion we had is that we could modify STLExtras.h to check
> > compiler version and just bring in the MSVC version of make_unique
> > into the llvm namespace if it's available, and otherwise define our
> > own. Then there wouldn't be an ambiguity.
> I've removed the comment and fully qualified the two other calls to
> make_unique in the same function in r208219. Two questions:
> 1. I guess we don't have buildbots with the right version of MSVC to hit
> this? I didn't get any email.
We don't have any bots running MSVC 2013. We support building LLVM with
two released versions of MSVC today: 2012 and 2013. This problem exists
> 2. Why wasn't the zero argument call to make_unique ambiguous?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits