[PATCH] [ASan tests] Use clang-cl to build tests on Windows

[Reid Kleckner]

Two things:

1. Should we add -o to clang-cl?  MSVC ignores it silently, and CMake
always uses it when it does its initial test compile.
2. Should we even use clang-cl when building compiler-rt?  Do we have lots
of CFLAGS in compiler-rt?  We will either have to expose them as core
clang-cl options, or switch to the regular clang driver.  Do you need this
to handle /MT or /MD?


On Thu, May 8, 2014 at 1:22 PM, Alexey Samsonov <samsonov at google.com> wrote:

> LGTM modulo nits.
>
> ================
> Comment at: CMakeLists.txt:65
> @@ +64,3 @@
> +    set(COMPILER_RT_TEST_COMPILER_EXE "-o")
> +    set(COMPILER_RT_TEST_COMPILER_OUT "-o")
> +  else()
> ----------------
> _OUT makes no sense to me. You can probably use EXE/OBJ instead.
>
> ================
> Comment at: cmake/Modules/AddCompilerRT.cmake:140
> @@ -140,1 +139,3 @@
> +    COMMAND ${COMPILER_RT_TEST_COMPILER} ${TEST_OBJECTS}
> +            ${COMPILER_RT_TEST_COMPILER_EXE}"${output_bin}"
>              ${TEST_LINK_FLAGS}
> ----------------
> Sanity check: is it ok to not have a space between
> ${COMPILER_RT_TEST_COMPILER_EXE} and "${output_bin}" ?
>
> http://reviews.llvm.org/D3680
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140508/f7648192/attachment.html>