[llvm] r208309 - Add isOSFreeBSD triple test

[Ed Maste]

On 8 May 2014 09:25, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> On Thu, May 08, 2014 at 01:00:15PM -0000, Ed Maste wrote:
>> Author: emaste
>> Date: Thu May  8 08:00:15 2014
>> New Revision: 208309
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=208309&view=rev
>> Log:
>> Add isOSFreeBSD triple test
>>
>> For http://reviews.llvm.org/D3448
>
> Wrong review? There is nothing in the review to need this.

Yes, sorry about that - I followed up to the corresponding clang
commit with a link to the correct review.  It should have been:
http://reviews.llvm.org/D3654.

> I find this not really helpful and just obscuring the source.

I don't disagree, but I preferred to be consistent what's already
there.  I'm happy enough to revert this and make the clang change
below, if that's preferable.

--- a/lib/Frontend/CompilerInvocation.cpp
+++ b/lib/Frontend/CompilerInvocation.cpp
@@ -340,7 +340,7 @@ static bool ParseCodeGenArgs(CodeGenOptions &Opts,
ArgList &Args, InputKind IK,
     // Until dtrace (via CTF) and LLDB can deal with distributed debug info,
     // Darwin and FreeBSD default to standalone/full debug info.
     if (llvm::Triple(TargetOpts.Triple).isOSDarwin() ||
-        llvm::Triple(TargetOpts.Triple).isOSFreeBSD())
+        llvm::Triple(TargetOpts.Triple).getOS() == llvm::Triple::FreeBSD)
       Default = true;