[PATCH] [ARM64] Re-work parsing of ADD/SUB shifted immediate operands

Bradley Smith bradley.smith at arm.com
Thu May 8 04:01:36 PDT 2014


Hi t.p.northover,

The parsing of ADD/SUB shifted immediates needs to be done explicitly so that better diagnostics can be emitted, as a side effect this also removes some of the hacks in the current method of handling this operand type.

Additionally remove manual CMP aliasing to ADD/SUB and use InstAlias instead.

There is no testcase for this fix since it is part of porting over MC/AArch64/basic-a64-diagnostics.s, which will be enabled for ARM64 once everything is fixed in it.

http://reviews.llvm.org/D3665

Files:
  lib/Target/ARM64/ARM64InstrFormats.td
  lib/Target/ARM64/ARM64InstrInfo.td
  lib/Target/ARM64/AsmParser/ARM64AsmParser.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3665.9206.patch
Type: text/x-patch
Size: 21224 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140508/9d8ed9aa/attachment.bin>


More information about the llvm-commits mailing list