[llvm] r208267 - Back out r208257 while I investigate tester failures.

Lang Hames lhames at gmail.com
Wed May 7 16:35:54 PDT 2014


Author: lhames
Date: Wed May  7 18:35:53 2014
New Revision: 208267

URL: http://llvm.org/viewvc/llvm-project?rev=208267&view=rev
Log:
Back out r208257 while I investigate tester failures.


Modified:
    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp

Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp?rev=208267&r1=208266&r2=208267&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp Wed May  7 18:35:53 2014
@@ -620,8 +620,6 @@ void RuntimeDyldImpl::resolveRelocationL
 }
 
 void RuntimeDyldImpl::resolveExternalSymbols() {
-  StringMap<RelocationList> ProcessedSymbols;
-
   while (!ExternalSymbolRelocations.empty()) {
     StringMap<RelocationList>::iterator i = ExternalSymbolRelocations.begin();
 
@@ -667,20 +665,8 @@ void RuntimeDyldImpl::resolveExternalSym
       resolveRelocationList(Relocs, Addr);
     }
 
-    ProcessedSymbols[i->first()] = i->second;
     ExternalSymbolRelocations.erase(i);
   }
-
-  // Restore the relocation entries that were consumed in the loop above:
-  //
-  // FIXME: Replace the following loop with:
-  //           std::swap(ProcessedSymbols, ExternalSymbolRelocations)
-  //        once StringMap has copy and move construction.
-  for (StringMap<RelocationList>::iterator I = ProcessedSymbols.begin(),
-                                           E = ProcessedSymbols.end();
-       I != E; ++I) {
-    ExternalSymbolRelocations[I->first()] = I->second;
-  }
 }
 
 //===----------------------------------------------------------------------===//





More information about the llvm-commits mailing list