[PATCH] Ignore/drop visibility for symbols with local linkage

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed May 7 09:34:52 PDT 2014

On 2014-May-07, at 05:31, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

>>>> 0005 clarifies `ModuleLinker::getLinkageResult()` with no
>>>> functionality change.
>>> This should be an assert I think. If the symbol is internal, we renamed it.
>> Good call; the updated patch changes it that way.
> Something went wrong when attaching this one:
> $ file  ~/Downloads/0005-LTO-Assert-visibility-of-local-linkage-when-mergin-2.patch
> /Users/espindola/Downloads/0005-LTO-Assert-visibility-of-local-linkage-when-mergin-2.patch:
> AppleSingle encoded Macintosh file

Weird.  Reattached.  Try again?

Just looking at this again, should the assert be stronger?  I.e., is
this even better?

    assert(!GlobalValue::isLocalLinkage(LT) &&
           "Symbols with local linkage should not be merged");

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-LTO-Assert-visibility-of-local-linkage-when-mergin-2.patch
Type: application/octet-stream
Size: 1122 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140507/2cb2f91a/attachment.obj>

More information about the llvm-commits mailing list