[PATCH] Support Itanium ABI like unwinding on ARM and use it for NetBSD

Joerg Sonnenberger joerg at britannica.bec.de
Wed May 7 04:23:17 PDT 2014


On Wed, May 07, 2014 at 08:49:37AM +0100, Renato Golin wrote:
> Hi Joerg,
> 
> I suppose Darwin's SjLj doesn't use this method, right?
> 
> const MCExpr *ARMElfTargetObjectFile::getTTypeGlobalReference()
> 
> +  if (TM.getMCAsmInfo()->getExceptionHandlingType() != ExceptionHandling::ARM)
> 
> Wouldn't it be better to be inclusive (DwarfCFI only), rather than exclusive?

No, it shouldn't be using this method. The assertion will pretty much
break any PIC use already, so using the sane default behavior makes a
lot more sense than the ARM specific behavior for any other EH method.

Joerg



More information about the llvm-commits mailing list