[PATCH] Caller/Calllee unsafe-fp-math attribute fixup prior to inlining.

Philip Reames listmail at philipreames.com
Tue May 6 11:43:39 PDT 2014

On 05/05/2014 03:12 PM, Chandler Carruth wrote:
> 3) add some more noisy guidance that textual attributes should only be 
> used for *target* attributes, not ones for which IR-optimizers are 
> semantically aware
Point 3 is the only part of this I disagree with.  One important 
secondary use for string attributes is while prototyping attributes.  
Adding a string attributes is _much_ easier than adding enum ones.  I've 
got several such string attributes in out of tree branches at the 
moment.  Most are planned for cleanup and submission (as full 
attributes), but being able to prototype them rapidly was very useful.

Ffor various reasons, none of the attributes I have interact with 
inlining.  So I can't really comment on the rest of the discussion.


More information about the llvm-commits mailing list