[llvm] r207943 - CodeGen: correct memset emittance for WoA

Anton Korobeynikov anton at korobeynikov.info
Mon May 5 13:59:22 PDT 2014


I bet the best thing would be to check the precise meaning of isAAPCS_ABI().

On Mon, May 5, 2014 at 6:17 PM, Saleem Abdulrasool
<compnerd at compnerd.org> wrote:
> It does conform to AAPCS (with some divergences), but not EABI.  Am I
> mistaken in that the two are different?
>
>
> On Sunday, May 4, 2014, Anton Korobeynikov <anton at korobeynikov.info> wrote:
>>
>> >    // Use default for non-AAPCS (or MachO) subtargets
>> > -  if (!Subtarget->isAAPCS_ABI() || Subtarget->isTargetMachO())
>> > +  if (!Subtarget->isAAPCS_ABI() || Subtarget->isTargetMachO() ||
>> > +      Subtarget->isTargetWindows())
>> >      return SDValue();
>> If it does not conform to EABI, the it should be handled by
>> !isAAPCS_ABI() case here. Why does it return true for you?
>>
>> --
>> With best regards, Anton Korobeynikov
>> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>
>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org



-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list