[PATCH] Implement Named Register Global Variables in LLVM

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Mon May 5 10:03:56 PDT 2014


+Warning: There is no register reservation at the moment, so it only

+works reliably on non-allocatable registers.


This is not entirely correct. It is not that allocatable registers
"don't work reliably". We reliably error on them. This should probably
be something like "the use of allocatable registers is rejected".


Other than that all the is missing I thing are tests for the errors.
Please include at lest two. One with a truly wrong name and one with
an allocatable register. On the test with the allocatable register
include a FIXME about producing a more specific error message.

http://reviews.llvm.org/D3261






More information about the llvm-commits mailing list