[PATCH] [InstructionMerge - GVN] hoisting and sinking of equivalent memory instructions in diamonds

[Gerolf Hoflehner]

I can see the arguments pro independent pass, but why do you assert it will make the code much easier to review? The code is coherent as it is and won’t change whether it is  part of GVN or its own phase. 

Thanks
Gerolf



On May 2, 2014, at 3:53 PM, Chandler Carruth <chandlerc at google.com> wrote:

> 
> On Fri, May 2, 2014 at 3:20 PM, Gerolf Hoflehner <ghoflehner at apple.com> wrote:
> I look at GVN as the place that handles equivalent computations (full and partial, since it also covers at least some PRE).
> On the other hand the current implementation of the InstructionMerge is independent of the GVN infrastructure and
> so could run as stand-alone pass with its merits and costs.
> 
> I would start off with it being an independent pass until it need some infrastructure from GVN. It also makes it much easier to review and test.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140502/e37d1113/attachment.html>