[PATCH] Remove dead code.

Rui Ueyama ruiu at google.com
Fri May 2 16:04:38 PDT 2014


Hi Bigcheese, shankarke, atanasyan,

isAlias always returns false and no one is using it. It was
originally added Atom to query if an atom is an alias for another
atom, assuming that alias atoms are different from normal atoms.

We now support atom aliasing, but the way that's implemented is
in a different way than what isAlias assumed. An alias atom is
just a regular defined atom with no content, and it has a layout-
before edge to alias-to atom so that they are layed out at the
same location in the result. So this is dead code, and it doesn't
make much sense to keep it.

http://reviews.llvm.org/D3599

Files:
  include/lld/Core/DefinedAtom.h
  include/lld/ReaderWriter/Simple.h
  lib/ReaderWriter/CoreLinkingContext.cpp
  lib/ReaderWriter/ELF/Atoms.h
  lib/ReaderWriter/Native/ReaderNative.cpp
  lib/ReaderWriter/Native/WriterNative.cpp
  lib/ReaderWriter/PECOFF/Atoms.h
  lib/ReaderWriter/YAML/ReaderWriterYAML.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3599.9048.patch
Type: text/x-patch
Size: 4988 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140502/42f04f12/attachment.bin>


More information about the llvm-commits mailing list