[llvm] r207565 - Add Simple return instruction to Mips fast-isel

[reed kotler]

On 04/29/2014 01:37 PM, Eric Christopher wrote:
> On Tue, Apr 29, 2014 at 1:34 PM, reed kotler <rkotler at mips.com> wrote:
>> On 04/29/2014 12:54 PM, Eric Christopher wrote:
>>>> +    TargetSupported = ((Subtarget->getRelocationModel() == Reloc::PIC_)
>>>> &&
>>>> +                       (Subtarget->hasMips32r2() &&
>>>> (Subtarget->isABI_O32())));
>>>>
>>> Seems limiting?
>>>
>>> -eric
>> I will do the other cases after this.
>>
>> We have a customer that needs this to work for -fPIC, mips32, integrated
>> assembler so that is the first priority.
>>
> Sure, it was just that I can't imagine that the code as checked in
> would matter yet.
>
> -eric
The next checkin which is out for review internally now for sure needs 
that because you can
assign values to global symbols.

But you are right, I could have delayed that other part you pointed out 
till the next checkin.