[PATCH] Modify the assertion in DIBuilder.cpp to cover the DWARF 5 languages

Eric Christopher echristo at gmail.com
Mon Apr 28 10:40:27 PDT 2014


Looks obvious assuming you've checked the values :)

-eric

On Sat, Apr 26, 2014 at 11:54 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> Hi echristo,
>
> http://reviews.llvm.org/D3523
>
> Files:
>   lib/IR/DIBuilder.cpp
>
> Index: lib/IR/DIBuilder.cpp
> ===================================================================
> --- lib/IR/DIBuilder.cpp
> +++ lib/IR/DIBuilder.cpp
> @@ -104,7 +104,7 @@
>                                             StringRef SplitName,
>                                             DebugEmissionKind Kind) {
>
> -  assert(((Lang <= dwarf::DW_LANG_Python && Lang >= dwarf::DW_LANG_C89) ||
> +  assert(((Lang <= dwarf::DW_LANG_OCaml && Lang >= dwarf::DW_LANG_C89) ||
>            (Lang <= dwarf::DW_LANG_hi_user && Lang >= dwarf::DW_LANG_lo_user)) &&
>           "Invalid Language tag");
>    assert(!Filename.empty() &&



More information about the llvm-commits mailing list