[PATCH] [ELF] Fix undefined symbol handling in DSO.

Michael Spencer bigcheesegs at gmail.com
Fri Apr 25 14:18:46 PDT 2014


On Fri, Apr 25, 2014 at 2:13 PM, Rui Ueyama <ruiu at google.com> wrote:
> On Fri, Apr 25, 2014 at 9:40 AM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>>
>> > Agreed here. Even if the expected behavior is different than what gnu
>> > ld does. As long as it doesn't break lots of things, we should do
>> > what's intended.
>> >
>> > As for this specific case, I have no idea what the correct behavior is.
>>
>> Correct is indeed a fuzzy concept in ELF :-(
>>
>> What is done by gold?
>
>
> Good point. I tried that and found that gold does *not* seem to try to
> resolve undefined symbols in DSOs. So my patch would make LLD more in line
> with GNU LD but that is something that gold does not really care about.
> Oops.
>
> Comparing the approaches of GNU LD and gold, gold's approach is better for
> performance.
>
> I'm now thinking to rework this patch to make it in line with gold, rather
> than GNU LD. That's probably what we should do.

Sounds good to me.

- Michael Spencer

>
>> Cheers,
>> Rafael
>
>




More information about the llvm-commits mailing list